RHEL-40693: netkvm lazy RX allocation of physical memory #1229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is preparation commit for lazy RX memory allocation. Depending on number of RX buffer we calculate the kick limit and low rx buffers limit. In future the number of RX buffers become variable and will be incremented during lazy memory allocation, so we will need to recalculate it at least several times, so move it to separate procedure. Signed-off-by: Yuri Benditovich <[email protected]>
|
rerun tests |
| @@ -353,6 +354,7 @@ static VOID ParaNdis6_Halt(NDIS_HANDLE miniportAdapterContext, NDIS_HALT_ACTION | |||
| { | |||
| PARANDIS_ADAPTER *pContext = (PARANDIS_ADAPTER *)miniportAdapterContext; | |||
| DEBUG_ENTRY(0); | |||
| pContext->systemThread.Stop(); | |||
There was a problem hiding this comment.
What about PM path like S4?
There was a problem hiding this comment.
Added commit for sync between power/reset flows and system thread actions
This procedure is to be called for lazy memory allocation, it allocates more RX buffers if needed. Return value indicates whether it should be called again for more allocations. Signed-off-by: Yuri Benditovich <[email protected]>
Signed-off-by: Yuri Benditovich <[email protected]>
Wrapper for process API system thread creation and stopping. Signed-off-by: Yuri Benditovich <[email protected]>
Jira link: https://issues.redhat.com/browse/RHEL-40693 Start the thread when the initialization is finished successfully, the thread starts allocate additional RX memory. On disable - the first thing to do is to stop the thread and wait until it is finished. Signed-off-by: Yuri Benditovich <[email protected]>
Synchronize lazy allocation operations with power down, power up, reset flows. Do the allocations only when the device is powered up, defer them otherwise. Signed-off-by: Yuri Benditovich <[email protected]>
Jira link: https://issues.redhat.com/browse/RHEL-40693 Initially allocate 16 buffers per RX queue, the rest of the buffers will be allocated by the system thread. Signed-off-by: Yuri Benditovich <[email protected]>
Change "bool Create" to "void Initialize", as the procedure can't fail and does not create anything. Signed-off-by: Yuri Benditovich <[email protected]>
Jira link: https://issues.redhat.com/browse/RHEL-40693 Currently we allocate 2x4K blocks for each TX descriptor. Chnaging it to one allocation of 8K, the allocated block is used exactly as before - 4K for headers area, 4K for indirect area. Signed-off-by: Yuri Benditovich <[email protected]>
Make lazy allocation configurable, enabled by default. Signed-off-by: Yuri Benditovich <[email protected]>
Signed-off-by: Yuri Benditovich <[email protected]>
Jira link: https://issues.redhat.com/browse/RHEL-40693 netkvm-wmi cfg has 2 additional metrics: InitTimeMs - time to 'init done' indication LazyAllocTimeMs - time to 'all allocations done' Signed-off-by: Yuri Benditovich <[email protected]>
|
rerun tests |
|
@kostyanf14 Can we please rerun just this test? |
|
@ybendito |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.